D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon May 13 15:38:49 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> apol wrote in framesvg.cpp:150
>   if (prefix.endsWith(QLatin1Char('-'))) {
>       return hasElement(prefix % QLatin1String("center"));
>   } else
>       return hasElement(prefix % QLatin1String("-center"));

But given the return, if the else needed? Actually some people recommend to not use else after return. I might be Monday blind, sorry :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190513/1dfbd99c/attachment.html>


More information about the Kde-frameworks-devel mailing list