D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Mon May 13 01:01:05 BST 2019


kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  d8a1a9eb084b19e552c789244267f7346e1b27a8 <https://phabricator.kde.org/R242:d8a1a9eb084b19e552c789244267f7346e1b27a8> changed the condition from
  hasElementPrefix(q->prefix()) to hasElementPrefix(frame->requestedPrefix)
  but it is not clear why, as the background is generated from the prefix
  data & the requestedPrefix is no-where in effect.
  As a result sometimes the background is not rendered for a given
  not-existing requestedPrefix which was mapped to an empty prefix instead.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixgeneratebackground

REVISION DETAIL
  https://phabricator.kde.org/D21175

AFFECTED FILES
  src/plasma/framesvg.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190513/235665f0/attachment.html>


More information about the Kde-frameworks-devel mailing list