D21106: FrameSvg: l & r borders or t & b don't need to have same height resp. width

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu May 9 21:20:02 BST 2019


kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The specification for FrameSvg does not require that all borders exist
  or that left & right and top & bottom borders have samples with the same
  size in the scalable dimension.
  The old assumption in the code broke e.g. themes which had special
  variants per screen side for the panel-background and left out elements
  for the border side which would not be rendered anyway, but only set a
  margin-hint. So e.g. for a panel on the east screen edge, without the
  left border element set, leftHeight would be 0 and as result also the
  right border not be painted due to an empty size.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixassumptionsvgframeborderelementsareequal

REVISION DETAIL
  https://phabricator.kde.org/D21106

AFFECTED FILES
  src/plasma/framesvg.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190509/981d1555/attachment.html>


More information about the Kde-frameworks-devel mailing list