D21028: add multiple gestures and a handler class to KWidgetsAddons

[Aleix Pol Gonzalez]

apol added a comment.


  It could make sense to run clazy on these, I'm pretty sure we'd find interesting stuff.

INLINE COMMENTS

> koneandtwofingerswipe.h:36
> +{
> +//    Q_PROPERTY(bool left READ left WRITE left)
> +//    Q_PROPERTY(bool right READ right WRITE right)

Why is this commented out?

> koneandtwofingerswipe.h:50
> +private:
> +    bool left;
> +    bool right;

If classes are installed and exported they should have a d-pointer.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190505/42b4d4e4/attachment-0001.html>