D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

Nathaniel Graham noreply at phabricator.kde.org
Thu May 2 20:29:41 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> apol wrote in kfilewidget.cpp:745
> Isn't it a bit weird to do this in setMimeFilter?

I did it in `setMimeFilter` since that's where it's determined whether or not there's a limited assortment of mimetypes, which is what controls what the string should be. Conditionalizing it based on mode seemed safe enough considering that there's mode-specific code a few lines above, on 741.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190502/d1d1d8da/attachment.html>


More information about the Kde-frameworks-devel mailing list