D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, elvisangelaccio, GB_2.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Filter combobox currently always has the label "Filter:" This is appropriate in most
  cases, but becomes inaccurate when saving with a limited list of mimetypes. In this case,
  the combobox loses its text field and becomes a file type chooser rather than a filter.
  
  This patch changes the label to "File type:" for that use case.
  
  BUG: 79903
  FIXED-IN: 5.59

TEST PLAN
  Opening a file: no changes
  F6803789: Filter when opening.png <https://phabricator.kde.org/F6803789>
  
  Saving a file with no mimetype filter: no changes
  F6803788: Filter when saving and mimetype is not defined.png <https://phabricator.kde.org/F6803788>
  
  Saving a file with a limited list of mimetypes: label is changed
  F6803790: File type when saving and mimetypes are defined.png <https://phabricator.kde.org/F6803790>

REPOSITORY
  R241 KIO

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190502/ec324548/attachment-0001.html>