D20961: [KJS] Allow calling function from KJObject by adding a call function to its api

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu May 2 12:49:02 BST 2019


apol added a comment.


  What are you using KJs for that needs such changes?

INLINE COMMENTS

> kjsobject.cpp:225
> +
> +    KJS::List args = List();
> +    foreach(KJSObject arg, arguments)

Just `KJS::List args;`

> kjsobject.h:149
> +     */
> +     KJSObject call(KJSContext *ctx, const QList <KJSObject> &arguments);
>      /**

Just pass a default argument = {} and the method doesn't need to be overloaded.

REPOSITORY
  R314 KJs

REVISION DETAIL
  https://phabricator.kde.org/D20961

To: ahmadosama
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190502/146a92eb/attachment.html>


More information about the Kde-frameworks-devel mailing list