D18604: Implement support for writing rating information for taglib writer

Stefan Brüns noreply at phabricator.kde.org
Sun Mar 31 22:13:57 BST 2019


bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:45
> +
> +#include <QDebug>
>  

Remove ...

> taglibwriter.cpp:71
> +int id3v2RatingTranslation[11] = {
> +    0,1,13,54,64,118,128,186,196,242,255
> +};

missing spaces

> taglibwriter.cpp:131
> +
> +}
> +

please add an end of anonymous namespace comment here, it is hard to spot otherwise

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190331/5fb91e29/attachment.html>


More information about the Kde-frameworks-devel mailing list