D20136: [UserMetaData] Handle changes in attribute data size correctly

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sat Mar 30 22:45:51 GMT 2019


bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is no guarantee the attribute size does not change between two
  getxattr calls (and the man page explicitly mentions this case).
  
  In case the attribute grows only a truncated value is returned, when it
  shrinks, garbage is returned. In both cases Unicode decoding errors can
  happen.

TEST PLAN
  ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20136

AFFECTED FILES
  src/xattr_p.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190330/4c83e2fb/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list