D18845: authority: add support for passing details to polkit

Matthias Gerstner noreply at phabricator.kde.org
Wed Mar 27 11:07:03 GMT 2019


mgerstner added inline comments.

INLINE COMMENTS

> chinmoyr wrote in polkitqt1-authority.cpp:336
> Nitpick; constData() because the API seems to take const gchar*

Strictly spoken it already returns `const gchar*`, since `toUtf8()` returns a `const QByteArray` temporary object and thus the `const char* data() const` member function should be called here.

Anways I will make it explicit like you suggest.

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: ngraham, mati865, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190327/f8d6afbc/attachment.html>


More information about the Kde-frameworks-devel mailing list