D20032: Convert string formatting tests to be data driven

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Mar 25 12:27:23 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> apol wrote in propertyinfotest.cpp:71
> Is the struct really necessary?
> You can be about as short by calling QTest::addRow directly for each line.

This saves adding the `QVariant(...)` around each value, and avoids the repeated formatting of the row name/data index. The property enum is used twice in each addRow.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190325/c9207841/attachment.html>


More information about the Kde-frameworks-devel mailing list