D18793: Handle text completion with block selection mode

Ahmad Samir noreply at phabricator.kde.org
Sun Mar 17 20:53:04 GMT 2019


ahmadsamir updated this revision to Diff 54149.
ahmadsamir added a comment.


  - Split the code responsible for inserting text in block selection from typeChars() to a new function
  - Don't add words where the block selection cursor is inside to the possible completion matches from the document
  - Add unit test

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18793?vs=52658&id=54149

BRANCH
  block-selection-completion-3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18793

AFFECTED FILES
  autotests/src/completion_test.cpp
  autotests/src/completion_test.h
  src/completion/katewordcompletion.cpp
  src/document/katedocument.cpp
  src/document/katedocument.h

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, mwolff
Cc: loh.tar, mwolff, kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190317/56a26c0b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list