D18845: authority: add support for passing details to polkit

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Sun Mar 17 15:19:17 GMT 2019


chinmoyr added a comment.


  I would like this patch to land so +1 from me. But I am not familiar with this code so I can't give any meaningful feedback. Sorry.

INLINE COMMENTS

> polkitqt1-authority.cpp:336
> +
> +        polkit_details_insert(ret, key.toUtf8().data(), value.toUtf8().data());
> +    }

Nitpick; constData() because the API seems to take const gchar*

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: mati865, kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190317/762b3cf7/attachment.html>


More information about the Kde-frameworks-devel mailing list