D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

Méven Car noreply at phabricator.kde.org
Sun Mar 17 13:11:12 GMT 2019


meven created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 385189
  "Save dialog: Return key only bound to Save button when text field has focus"
  
  Draw inspiration from inspiration from https://phabricator.kde.org/D12538 for reference.
  
  First attempt, not necessarly the right one.
  But I think it points out the issue at hand:
  
  - the KDirOperator at the moment does not signal when it received an enter/return event when it should.
  - This prevents expected behavior

TEST PLAN
  1 Compile an that uses kio open save dialog
  2 Save a file in the app
  3 choose a filename
  4 click on an place on the left
  5 Hit enter

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19824

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: meven
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190317/d20c8d58/attachment.html>


More information about the Kde-frameworks-devel mailing list