D17469: Give applications-games more contrast with Breeze Dark

Noah Davis noreply at phabricator.kde.org
Thu Mar 14 02:19:07 GMT 2019


ndavis added a comment.


  In D17469#430647 <https://phabricator.kde.org/D17469#430647>, @ngraham wrote:
  
  > Hmm, I see what you mean. Okay, let's go with this one!
  >
  > BTW, the duplicate test fails as of f2509047d4372f1a59d8f8b5ff009146f1a6adcb <https://phabricator.kde.org/R266:f2509047d4372f1a59d8f8b5ff009146f1a6adcb>:
  >
  >   ********* Start testing of DupeTest *********
  >   Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.3.0)
  >   PASS   : DupeTest::initTestCase()
  >   FAIL!  : DupeTest::test_duplicates() 
  >     The following files are duplicates but not links:
  >       - /home/dev/kde/src/breeze-icons/icons/actions/22/go-up.svg
  >       - /home/dev/kde/src/breeze-icons/icons/actions/24/go-up.svg
  >  
  >      Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  >   FAIL!  : DupeTest::test_duplicates() 
  >     The following files are duplicates but not links:
  >       - /home/dev/kde/src/breeze-icons/icons-dark/actions/22/go-up.svg
  >       - /home/dev/kde/src/breeze-icons/icons-dark/actions/24/go-up.svg
  >  
  >      Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  >
  >
  > Do you think you could fix that after landing this?
  
  
  Looks like I forgot to make the icon actually 24 px when I copied in the 22px version. I'll be sure to fix that.
  
  I should probably also update the 64px device icons for gamepads to match this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190314/42ec9443/attachment.html>


More information about the Kde-frameworks-devel mailing list