D19532: Don't crash when no contexts are present

Volker Krause noreply at phabricator.kde.org
Wed Mar 6 17:17:23 GMT 2019


vkrause added a comment.


  In D19532#425432 <https://phabricator.kde.org/D19532#425432>, @cullmann wrote:
  
  > Ok with that.
  >  Volker, ok, too?
  >  I think the if(...isLoaded) removal is a diff artifact, that was never in the original code bug just in the first try here.
  
  
  Yep, replacing the assert certainly makes sense. This would assume though that the caller of initalContext() expects a nullptr return value already, which I guess is the case if this doesn't crash somewhere else now :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19532

To: davispuh, cullmann, dhaumann, vandenoever, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190306/3f7be58a/attachment.html>


More information about the Kde-frameworks-devel mailing list