D21661: add snoretoast backend for KNotifications on Windows

[Albert Vaca Cintora]

albertvaka added inline comments.

INLINE COMMENTS

> notifybysnore.h:45
> +    QMap<int, QPointer<KNotification>> m_notifications;
> +    QString program = QStringLiteral("SnoreToast.exe");
> +    QLocalServer *server;

Isn't LibSnore abstracting this? Why do we need to call the exe instead of using some method in LibSnore?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190609/9c7688da/attachment.html>