D22723: Fix RunnerManager::queryFinished()

[Aleix Pol Gonzalez]

apol added a comment.


  > If you don't like it I won't object landing this internal class, but please add a long comment explaining why it was done like this.
  
  QObjects live in their own thread and shouldn't be used outside.
  https://doc.qt.io/qt-5/qobject.html#thread
  
  In your patch we are emitting the signal from the run thread instead of the actual object's thread. This is wrong.
  
  Also I'd say there's value in using tools (i.e. Threadweaver) as it's meant to be used, despite you don't liking its semantics.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190726/92ff9783/attachment.html>