D22730: KZip::openArchive: Remove "bad" assert

Albert Astals Cid noreply at phabricator.kde.org
Wed Jul 24 23:21:51 BST 2019


aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  There's nothing the caller of this function can do to control the assert
  condition, so asserting is "too rude", and on top of that there's
  a perfectly valid if below that already handles the condition properly

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22730

AFFECTED FILES
  src/kzip.cpp

To: aacid
Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190724/1d885f4d/attachment.html>


More information about the Kde-frameworks-devel mailing list