D22698: Support passing target to ki18n_wrap_ui macro
Christophe Giboudeaux
noreply at phabricator.kde.org
Wed Jul 24 08:47:42 BST 2019
cgiboudeaux added inline comments.
INLINE COMMENTS
> KF5I18nMacros.cmake.in:72
> + if(TARGET ${_sources})
> + cmake_minimum_required(VERSION 3.1)
> + target_sources(${_sources} PRIVATE ${_header})
same thing as D22699 <https://phabricator.kde.org/D22699>. A macro must not change the minimum required version. (ki18n already requires CMake 3.5 anyway)
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D22698
To: daandemeyer, ilic
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190724/9844f43b/attachment.html>
More information about the Kde-frameworks-devel
mailing list