D21660: remove dbus for windows build and change audio dep logic

Alexander Potashev noreply at phabricator.kde.org
Tue Jul 23 03:33:05 BST 2019


aspotashev added a comment.


  This broke some public APIs on Windows: since Qt5DBus is not being "imported" by CMake, a group of .cpp files is not being compiled, see e.g. https://cgit.kde.org/knotifications.git/tree/src/CMakeLists.txt#n25 . Thus e.g. class KStatusNotifierItem implementation becomes unavailable at linking time, even though CMake configuration installs the respective header files.
  
  As a consequence, we have linking errors in applications that rely on KStatusNotifierItem: https://phabricator.kde.org/T11275

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190723/0c3be225/attachment.html>


More information about the Kde-frameworks-devel mailing list