D22617: Add icons for pagelayout options, as needed in Okular

Nathaniel Graham noreply at phabricator.kde.org
Sun Jul 21 23:30:41 BST 2019


ngraham added a reviewer: ndavis.
ngraham added a comment.


  The 16px version is used in menus. The 22px version is used in toolbar buttons. 24px is unnecessary; it's only used by some 3rd-party apps I think. The ones that are already in there at that size are legacy and maybe we should just delete them? 32px is used for category icons and should be colorized. In general there isn't a reason to create monochrome 24x or 32px icons (and the few places where we are actually using 32px monochrome icons should be changed IMO; see T10165 <https://phabricator.kde.org/T10165>). When in doubt, if it's a monochrome action icon, you can safely make 16px and 22px versions and call it a day.
  
  This definitely needs some cleanup in the documentation, for sure.
  
  In terms of the icons themselves, they look good! I have a visual change request though: could you put the page curl on the top rather than on the bottom. That's the general style that most Breeze document icons use, and it would be good to use that. Basically just vertically flipping the icons should be sufficient.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190721/9b70650b/attachment.html>


More information about the Kde-frameworks-devel mailing list