D22557: [IndexCleaner] ignore non-existent entries inside config

Igor Poboiko noreply at phabricator.kde.org
Fri Jul 19 12:37:38 BST 2019


poboiko created this revision.
poboiko added reviewers: Baloo, bruns, ngraham.
Herald added projects: Frameworks, Baloo.
poboiko requested review of this revision.

REVISION SUMMARY
  If a folder was added to include/excludeFolders and then removed,
  there will be a stale entry in the config, for which `filePathToId`
  yields 0. When passed to `removeRecursively`, it might reinterpret it
  as tree root, which is not something we want (although there are
  checks for it inside `WriteTransaction`)
  
  See also D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders <https://phabricator.kde.org/D22502>

REPOSITORY
  R293 Baloo

BRANCH
  no-indexcleaner-assert (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22557

AFFECTED FILES
  src/file/indexcleaner.cpp

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190719/00b88e45/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list