D22083: introduce concept of header and footer for kpageview

Marco Martin noreply at phabricator.kde.org
Wed Jul 17 08:26:41 BST 2019


mart added a comment.


  In D22083#496446 <https://phabricator.kde.org/D22083#496446>, @ngraham wrote:
  
  > Lovely. Looks perfect in Dolphin, Kate, Konsole, Okular, Gwenview, and Kile.
  >
  > Ark and Spectacle also need to be adapted, like kcmshell. Anything not using KPageView properly will need some adjustment, I guess. It's probably good that we're doing this because it provides a good opportunity to fix them and unify things.
  
  
  one thing that concerns me is that things that need to be adapted now get a double margin.
  tough i guess if we remove margins completely from the dialogs it doesn't look that good anymore...

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  mart/pageviewfooter

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg, ngraham
Cc: hpereiradacosta, cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190717/fd0cd000/attachment.html>


More information about the Kde-frameworks-devel mailing list