D21672: [PowerStateMonitor] Be conservative when determining power state

Stefan BrĂ¼ns noreply at phabricator.kde.org
Tue Jul 16 11:15:28 BST 2019


bruns added a comment.


  In D21672#496217 <https://phabricator.kde.org/D21672#496217>, @romangg wrote:
  
  > Reverted by d6d86cb86c <https://phabricator.kde.org/R293:d6d86cb86cb631a0d736858ecdf2efb71c20172f> on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a critical problem in released 5.60 @bruns.
  
  
  Why don't you notify the relevant people first and **then** submit a **review**.
  
  Just reverting a commit without reasoning, without review is just wrong.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21672

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: romangg, kde-frameworks-devel, #baloo, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190716/0fedf22b/attachment.html>


More information about the Kde-frameworks-devel mailing list