D22147: Better use of Qt APIs in Plasma::Theme

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> svg.cpp:339-364
>          if (!elementSizeHints.isEmpty()) {
>              QSize bestFit(-1, -1);
>  
> -            Q_FOREACH (QSize hint, elementSizeHints) {
> +            for (const QSize &hint : elementSizeHints) {
>  
>                  if (hint.width() >= s.width() * ratio && hint.height() >= s.height() * ratio &&
>                          (!bestFit.isValid() ||

What's this doing? it seems that it calculates the bestFit just to discard later.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22147

To: apol, #plasma, #frameworks, fvogt
Cc: tcanabrava, fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190701/0d03085a/attachment.html>