D21204: Ensure mounted mounted nfs filesystems matches their fstab declared counterpart

Méven Car noreply at phabricator.kde.org
Mon Jul 1 10:32:05 BST 2019


meven added a comment.


  In D21204#488719 <https://phabricator.kde.org/D21204#488719>, @dhaumann wrote:
  
  > Minor/general comment: given this is a KDE Frameworks change, could you improve the summary of the commit message for this and future commits? Here it just says bug, ccbug, fixedin. Imho a commit log should be self-explaining and self-contained: what is broken exactly, why is it broken, why is the suggested fix correct, what testing did you do, what possible risks does the change have?
  >
  > Everything is missing here. As consequence, you get poor or no reviews, and no one feels good enough giving a ship-it.
  
  
  Thank you for pointing this out, this is already great feedback.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190701/08017b20/attachment.html>


More information about the Kde-frameworks-devel mailing list