D18603: Implement more tags for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwritertest.cpp:276
> +        QFAIL("This mime type is not supported by the extractor. Likely a newer KDE Frameworks version is required.");
> +    KFileMetaData::Extractor* ex = extractorList.first();
> +    KFileMetaData::SimpleExtractionResult result(testFilePath(temporaryFileName), mimeType,

You should probably add a warning when `extractorList.size() > 1`, as in this case the extractor you run would be arbitrary.

Though, I am currently not aware of cases where one mimetype is supported by several extractors.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190131/35d64850/attachment.html>