D11235: [DrKonqi] Request change of ptrace scope from KCrash

Oswald Buddenhagen noreply at phabricator.kde.org
Thu Jan 17 12:07:39 GMT 2019


ossi added a comment.


  you got the parent-child ordering wrong in the commit message. ^^

INLINE COMMENTS

> ptracer.cpp:61
> +        char msg[msize], rmsg[msize];
> +        int bytes = 0, r;
> +        sprintf(msg, "%lld", debuggerpid);

this looks stupid, i'd swap the order.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190117/18414ae2/attachment.html>


More information about the Kde-frameworks-devel mailing list