D11236: [KCrash] Establish socket to allow change of ptrace scope

Christoph Roick noreply at phabricator.kde.org
Tue Jan 15 16:59:36 GMT 2019


croick added a comment.


  In D11236#393063 <https://phabricator.kde.org/D11236#393063>, @ossi wrote:
  
  > yay, i finally have "some" time for this. ^^
  
  
  Great! :) And thanks for your input.
  
  > it took me a while to get a coherent picture of the problem and solution, because your description unnecessarily dwells on the irrelevant cases of ptrace restrictions, but omits the crucial fact that this is about tracers that are not descendant processes of drkonqi, specifically kdevelop launched via kdeinit. see also comment on DefaultDebuggerLauncher in the complementary change. please make sure to point that out in the commit messages.
  
  Actually it's only the internal process that creates the backtraces, that is a descendant of DrKonqi. All debuggers that are launched via the "Debug" button are processes on their own (to remain alive, even if DrKonqi already quit). But I will change the commit message to point that out.

INLINE COMMENTS

> ossi wrote in kcrash.cpp:655
> you need to cover that branch as well.

What an oversight :/ Will do of course.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190115/3e6ebfd1/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list