D10716: handle wrong password when using sudo which asks for another password

Fabian Vogt noreply at phabricator.kde.org
Thu Jan 10 15:57:33 GMT 2019


fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> suprocess.cpp:124
> +    if (d->testMode) {
> +        args += QByteArray(CMAKE_RUNTIME_OUTPUT_DIRECTORY) + "/kdesu_stub";
> +    } else {

This means the path to the build directory is hardcoded in the executable. That needs to be avoided to make builds fully reproducible (https://reproducible-builds.org/).

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190110/4d84f5af/attachment.html>


More information about the Kde-frameworks-devel mailing list