D17528: Refactor SlaveInterface::calcSpeed

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> slaveinterface.cpp:106
> +    const qint64 elapsed_time = d->elapsed_timer.elapsed();
> +    if (elapsed_time >= 900) {
> +        if (d->transfer_details.count() == max_count) {

That wasn't there in the old code because it has this guard:

const qint64 diff = currentTime - d->start_time;

(effectively calculating elapsed)

Then

if (diff - d->last_time >= 900) {

So we known first-last is non-zero

Should the new code be

https://phabricator.kde.org/P287 ?

It seemed to work for me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: davidedmundson, broulik, bruns, kde-frameworks-devel, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190110/60063f15/attachment.html>