D18137: delete copy constructor and assignment operator of some public classes

Albert Astals Cid noreply at phabricator.kde.org
Wed Jan 9 21:05:03 GMT 2019


aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If someone was using them, it'd crash since it was raw-copying the d pointer
  so you would end up with a double delete.
  
  This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18137

AFFECTED FILES
  src/lib/caching/kshareddatacache.h
  src/lib/util/kdelibs4configmigrator.h
  src/lib/util/kdelibs4migration.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190109/d97c1e19/attachment.html>


More information about the Kde-frameworks-devel mailing list