D17911: Fix failing knewfilemenu test and underlying reason for its failure

David Faure noreply at phabricator.kde.org
Sun Jan 6 19:13:23 GMT 2019


dfaure accepted this revision.
dfaure added inline comments.

INLINE COMMENTS

> knewfilemenutest.cpp:170
> +                dialog->accept();
> +                path = "";
> +            } else {

path.clear() or path = QString() would be better; but ok this is only a unittest ;)

REPOSITORY
  R241 KIO

BRANCH
  fix-test-and-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17911

To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190106/88adf7be/attachment.html>


More information about the Kde-frameworks-devel mailing list