D17911: Fix failing knewfilemenu test and underlying reason for its failure

Nathaniel Graham noreply at phabricator.kde.org
Sat Jan 5 04:07:42 GMT 2019


ngraham added a comment.


  In D17911#386581 <https://phabricator.kde.org/D17911#386581>, @dfaure wrote:
  
  > Hmm, let me read the unittest more closely.
  >
  > The scenario is: "New Folder" exists. The user asks to create a new folder, the initial suggestion in the dialog is "New Folder (1)". The user removes the (1), and hits OK, i.e. the user is asking to create "New Folder" again.
  
  
  This is now an error condition. So maybe the test should check to make sure it fails?

REPOSITORY
  R241 KIO

BRANCH
  fix-test-and-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17911

To: ngraham, #frameworks, dfaure, elvisangelaccio, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190105/e450b65e/attachment.html>


More information about the Kde-frameworks-devel mailing list