D17593: Notify if a default provider failed to download

David Faure noreply at phabricator.kde.org
Fri Jan 4 21:20:39 GMT 2019


dfaure added a comment.


  The unittest failed. I kind of fixed it (see commit 32a662b <https://phabricator.kde.org/R235:32a662b88e9b684530a4fb4caf55aca62697eaf9>), and my fix works, but it's ugly, it still waits for 5s instead of using that failedToLoad signal.
  
  However when requiring the signal to be emitted (see patch below), the test is unstable (sometimes it passes, sometimes it fails -- ProviderManager::fileFinished isn't called). Any idea why?
  
  http://www.davidfaure.fr/2019/0001-autotests-use-new-signal-failedToLoad-in-ProviderTes.patch

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D17593

To: apol, #frameworks, leinir
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190104/c4d2d2bd/attachment.html>


More information about the Kde-frameworks-devel mailing list