kconf_update lost its update.log in 2014

[Albert Astals Cid]

El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va escriure:
> ...and I don't understand why
> 
> Hi!
> 
> this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0`
> and thus disabling the update.log writing, replacing it with logging
> to stderr instead. Why it does that eludes me though. It seems
> entirely unrelated to the rest of the commit.

Yep, maybe he was testing on windows, that code had issues on windows, disabled it for the moment and then forgot to reenable?

Sound we try CC'ing Alex Richardson in case he remembers? Or you did and it got lost because he's on the list?

> Should the update.log writing happen? I expect this won't be super
> reliable because I think these days the application itself forks
> kconf_update. 

I don't understand what you mean with this. kconf_update has always been its own application as far as i know. 

Cheers,
  Albert

> If so, we should just drop the if block and update
> documentation accordingly I guess (e.g. see [2])
> 
> [1] https://cgit.kde.org/kconfig.git/commit/?id=94419b6f0cd469dc7cb0184a6fb48c1fe304c4d8
> [2] https://bugs.kde.org/show_bug.cgi?id=404904
>