D19395: [KJobWidget] remove deprecated method

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:47
>                          SOVERSION 5)
> -
> +#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000)
>  

Since it's commented out, it's not really useful to add it.

And yeah we can't add it yet, since new things might become deprecated with 6.0.

Maybe you could add it with 0x050C00 (5.12) at least [assuming this is the right value, please check], and we can then upgrade all of that with a script once 6.0 is out? (after checking that everything compiles)

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D19395

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190227/e7d4a9dd/attachment.html>