D19332: KProcess compile fix for obsolete QProcess members in 5.13

Jonathan Marten noreply at phabricator.kde.org
Tue Feb 26 15:39:23 GMT 2019


marten added inline comments.

INLINE COMMENTS

> apol wrote in kprocess.h:332
> Also should check for QT_DISABLE_DEPRECATED_BEFORE no?

Do you mean conditionalise instead on #if !QT_DEPRECATED_SINCE(5, 13), so that if the functions are not disabled in Qt then they are hidden here?  That would work, although QT_DEPRECATED_SINCE is not public API or defined in the Qt documentation.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D19332

To: marten, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190226/6967cf57/attachment.html>


More information about the Kde-frameworks-devel mailing list