D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

Pino Toscano noreply at phabricator.kde.org
Sat Feb 23 15:11:19 GMT 2019


pino added a comment.


  In D18798#418024 <https://phabricator.kde.org/D18798#418024>, @ngraham wrote:
  
  > In D18798#414082 <https://phabricator.kde.org/D18798#414082>, @ngraham wrote:
  >
  > > @Pino, can you help fix us the root cause then? The reason why we've resorted to these workarounds is because nobody's been able to adequately understand the root cause or implement a risk-free fix.
  >
  >
  > Ping. The workaround is known to work and cause no regressions, and I see no reason to torture our users with broken behavior for any longer. I would like to land this for Frameworks 5.56 if we aren't going to be able to work on fixing the root cause anytime soon.
  
  
  The workaround is still a bad workaround, and as such ought to not be in a general-purpose framework such as KIO.
  
  Sorry, I don't have the time to also dig into this issue myself; OTOH, this is not a reason for accepting such broken code.
  
  Also, please do not resort to psychological tricks like "torture our users", as if this is any worse than any behaviour issues there.
  
  Stilla big -1, sorry. You will need a KIO maintainer for their opinion on this "patch".

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18798

To: anemeth, #frameworks, kde-frameworks-devel, ngraham, davidedmundson
Cc: pino, elvisangelaccio, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190223/19211eca/attachment.html>


More information about the Kde-frameworks-devel mailing list