D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

Stefan Brüns noreply at phabricator.kde.org
Thu Feb 21 15:04:28 GMT 2019


bruns created this revision.
bruns added reviewers: Frameworks, Baloo, astippich, ngraham.
Herald added a project: Baloo.
bruns requested review of this revision.

REVISION SUMMARY
  There is no need to do any Base64 encoding of the data. Also avoid
  streaming the data to an intermediate QByteArray, but directly stream
  to stdout.

TEST PLAN
  PATH=`pwd`/bin/:$PATH  ctest

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19202

AFFECTED FILES
  autotests/extractortest.cpp
  src/extractor.cpp
  src/indexeddataretriever.cpp

To: bruns, #frameworks, #baloo, astippich, ngraham
Cc: ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190221/e58c04df/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list