D19051: [RFC]DocumentPrivate: Auto unwrap line when text is removed

loh tar noreply at phabricator.kde.org
Fri Feb 15 19:11:19 GMT 2019


loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Such patch seems to be missing to achieve the desired behavior to auto
  reformat a paragraph with enabled static word wrap.
  
  The reformat takes without this patch only place when text is added but
  not removed.

TEST PLAN
  - Enable static wrap
  - Enter enough text to force auto wrap over a couple of lines
  - Add at some point in the middle of your text a "hard wrap/new paragraph" by simply press ENTER
  - Add in the upper paragraph more text -> lines below will auto reformat down to "hard wrap"
  - Remove new added text by DEL -> with patch paragraph gets reformat too
  - New behavior also affects text which was wrapped by "Apply Word Wrap" when static wrap is off, but for me is that's fine
  - It's looking similar as done at other places but I'm not sure if it's best this way due to my goals mentioned elsewhere
  - In current state can this patch crash when do "undo"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19051

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190215/8bb7f489/attachment.html>


More information about the Kde-frameworks-devel mailing list