D19007: Wait for DBus Reply Before Performing Computations

Stefan BrĂ¼ns noreply at phabricator.kde.org
Fri Feb 15 01:54:15 GMT 2019


bruns added a comment.


  good catch, but the fix is overengineered ...

INLINE COMMENTS

> monitor.cpp:90
> +    batchSize.waitForFinished();
>  
> +    if (!batchSize.isError()) {

much more trivial:

  auto updateInterval = std::max(100, 5 * m_scheduler->getBatchSize());
  if (m_filesIndexed % updateInterval == 0) { ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190215/4b70abbf/attachment.html>


More information about the Kde-frameworks-devel mailing list