D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

Harald Sitter noreply at phabricator.kde.org
Tue Feb 12 14:41:31 GMT 2019


sitter added a comment.


  Generally yes, I am not sure we can do that very well for 5.x though. The LIBEXEC_INSTALL_DIR where `kioslave` is installed is controlled by ECM, that's where the conditional split between suffix-or-not happens, so unless we add another LIBEXEC_INSTALL_DIR_REAL which does away with the conditional and then explicitly install kioslave using LIBEXEC_INSTALL_DIR_REAL I don't think we can fix it. (and a second LIBEXEC var may only be confusing; the thought of it certainly doesn't excite me).
  
  from KDEInstallDirs.cmake
  
    if(WIN32)
        _define_relative(LIBEXECDIR BINDIR ""
            "executables for internal use by programs and libraries"
            LIBEXEC_INSTALL_DIR)
        _define_non_cache(LIBEXECDIR_KF5 "${CMAKE_INSTALL_LIBEXECDIR}")
    else()
        _define_relative(LIBEXECDIR LIBDIR "libexec"
            "executables for internal use by programs and libraries"
            LIBEXEC_INSTALL_DIR)
        _define_non_cache(LIBEXECDIR_KF5 "${CMAKE_INSTALL_LIBEXECDIR}/kf5")
    endif()

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18725

To: sitter, davidedmundson, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/ff6c74b0/attachment.html>


More information about the Kde-frameworks-devel mailing list