D18950: KCompressionDevice: reset error in open() to allow reuse of object

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Feb 12 14:33:38 GMT 2019


apol added inline comments.

INLINE COMMENTS

> kcompressiondevice.cpp:159
>      }
> +    d->resetErrorCode();
>      d->bOpenedUnderlyingDevice = false;

Can't you just reset it here without creating a new function that is just used once?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D18950

To: mgerstner
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190212/2121e303/attachment.html>


More information about the Kde-frameworks-devel mailing list