D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Nathaniel Graham]

ngraham added a comment.


  In D18904#409667 <https://phabricator.kde.org/D18904#409667>, @chinmoyr wrote:
  
  > @ngraham The destination file is corrupted as soon as the user clicks overwrite.
  
  
  That's exactly the problem we need to fix.
  
  For example, if the user starts an overwrite by accident and then cancels it, their original file in the destination has been destroyed. This is bad. Canceling an accidental action should never be destructive.
  
  That's why I'm recommending that for overwrite operations, we don't instantly delete or start overwriting the destination file, but rather move or copy the source file to a separate location, and //then// overwrite the destination file. This preserves the user's ability to cancel the job during the move or copy portion of the operation without destroying their own files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190211/1d35a89b/attachment.html>