D18813: Filter out invalid content in lists

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Fri Feb 8 11:45:28 GMT 2019


leinir marked an inline comment as done.
leinir added inline comments.

INLINE COMMENTS

> apol wrote in atticaprovider.cpp:277
> Maybe it would be easier to read if we had a `if (!content.isValid()) continue; ...`.

Hmm... the patch certainly would, i'll swap that around a bit. Generally don't like negations too much if i can avoid them, hunting exclamation marks just gets tiring after a while, but yeah, smaller patch is good anyway :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18813

To: leinir, #knewstuff
Cc: apol, kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190208/e4a3887c/attachment.html>


More information about the Kde-frameworks-devel mailing list