D18604: Implement support for writing rating information for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:229
> +            writeID3v2Tags(file.ID3v2Tag(), properties);
> +        }
>          file.save();

Is this the same as

  auto id3Tags = dynamic_cast<TagLib::ID3v2::Tag*>(file.tag());
  if (id3Tags) { ... }

?

> taglibwriter.cpp:279
> +        if (mp4Tags) {
> +            qDebug() << QStringLiteral("enter");
> +            writeMp4Tags(mp4Tags, properties);

leftover ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190204/a8b0d863/attachment-0001.html>