D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

Aleix Pol Gonzalez noreply at phabricator.kde.org
Tue Dec 31 18:51:00 GMT 2019


apol added inline comments.

INLINE COMMENTS

> CppGenerator.cpp:61
>          writeCopyrightHeader(stream);
> -        stream << "#pragma once" << endl << endl;
> -        stream << "#include <QDBusAbstractAdaptor>" << endl << endl;
> -        stream << "class QDBusObjectPath;" << endl << endl;
> -        stream << "namespace BluezQt" << endl << "{" << endl << endl;
> -        stream << "class " << className << ";" << endl << endl;
> -        stream << "class " << className << "Adaptor : public QDBusAbstractAdaptor" << endl << "{" << endl;
> -        stream << "    Q_OBJECT " << endl;
> -        stream << "    Q_CLASSINFO(\"D-Bus Interface\", \"" << interface.name() << "\")" << endl;
> +        stream << "#pragma once" << "\n" << "\n";
> +        stream << "#include <QDBusAbstractAdaptor>" << "\n" << "\n";

I'd either merge into the line or at least use '\n'.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/b6adb874/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list