D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

Albert Astals Cid noreply at phabricator.kde.org
Tue Dec 31 11:21:49 GMT 2019


aacid added a comment.


  Isn't it better to just use `Qt::endl` ?
  
  I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')`
  
  But if we prefer to change to use \n it should be merged into the existing strings, doesn't make much sense to do 
  `outStream << "</l:i18n>" << QLatin1Char('\n');`
  instead of
  `outStream << "</l:i18n>\n';`

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26317

To: mlaurent, dfaure
Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20191231/32a4126b/attachment.html>


More information about the Kde-frameworks-devel mailing list